This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Add feature to create multiple accounts - Closes #423 #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
force-pushed
the
604-update_readme
branch
from
e83e153 to
91d7139
Compare
shuse2
force-pushed
the
423-add_multiple_account_create
branch
from
f9d6256 to
ec348a4
Compare
shuse2
changed the title
willclarktech
previously requested changes
Sep 17, 2018
shuse2
force-pushed
the
423-add_multiple_account_create
branch
from
d8d133d to
5b545b3
Compare
willclarktech
previously requested changes
Sep 19, 2018
src/commands/account/create.js
Outdated
| ) { | ||
| throw new Error('Number flag must be an integer and greater than 0'); | ||
| } | ||
| const accounts = Array(number) |
test/commands/account/create.test.js
Outdated
| sandbox.stub().returns(defaultAddress), | ||
| sandbox | ||
| .stub() | ||
| .onFirstCall() |
There was a problem hiding this comment.
.withArgs is more robust in this case.
willclarktech
approved these changes
Sep 20, 2018
…hange values to realistic values
shuse2
force-pushed
the
423-add_multiple_account_create
branch
from
b55fc02 to
08b34cb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, account can only be created one command per one, so the flag that can create multiple account is added.
Review checklist