This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Migrate transaction commands - Partially closes #558 #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
changed the title
shuse2
force-pushed
the
571-migrate_signature_command
branch
from
768f5f5 to
04cd30a
Compare
shuse2
force-pushed
the
558-migrate_transaction_commands
branch
from
d6e20aa to
33e918e
Compare
shuse2
force-pushed
the
558-migrate_transaction_commands
branch
from
33e918e to
c8391e8
Compare
shuse2
force-pushed
the
558-migrate_transaction_commands
branch
from
c8391e8 to
3a59cd1
Compare
willclarktech
suggested changes
Sep 17, 2018
willclarktech
previously requested changes
Sep 17, 2018
willclarktech
previously requested changes
Sep 19, 2018
test/utils/transactions.js
Outdated
| ); | ||
| }); | ||
|
|
||
| it('should throw an validation error when the input is not valid JSON format', () => { |
| ) | ||
| .command(['transaction:broadcast']) | ||
| .it('should broadcast the transaction', () => { | ||
| expect(apiClientStub.transactions.broadcast).to.be.calledWithExactly( |
There was a problem hiding this comment.
This should also test the API config.
willclarktech
approved these changes
Sep 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration from
npm t./bin/run transaction:get./bin/run transaction:broadcast./bin/run transaction:sign./bin/run transaction:verifyReview checklist