Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Add validate transaction on signTransaction #532

Closed
shuse2 opened this issue May 24, 2018 · 1 comment
Closed

Add validate transaction on signTransaction #532

shuse2 opened this issue May 24, 2018 · 1 comment
Assignees
@shuse2
Labels
*medium 🌱 enhancement

Comments

@shuse2
Copy link
Contributor

shuse2 commented May 24, 2018

Description

On sign transaction command, there is no validation on input.
Once we have validation function on lisk-elements, we should use that to validate the schema of the transaction before verifying the transaction.

Versions

1.0
@willclarktech
Copy link
Contributor

Depends on LiskArchive/lisk-elements#676

@shuse2 shuse2 self-assigned this Nov 5, 2018
@shuse2 shuse2 mentioned this issue Nov 5, 2018
Merged
shuse2 added a commit that referenced this issue Nov 9, 2018
@shuse2
Merge pull request #641 from LiskHQ/532-validate_tx_before_sign
303561c 
Add validation before signing for transaction - Closes #532
@shuse2 shuse2 closed this as completed Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
*medium 🌱 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shuse2 @willclarktech