Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Add validate transaction method #676

Closed
shuse2 opened this issue May 24, 2018 · 4 comments
Closed

Add validate transaction method #676

shuse2 opened this issue May 24, 2018 · 4 comments

Comments

@shuse2
Copy link
Contributor

shuse2 commented May 24, 2018

Description

Currently we have verify transaction, whether signature is correct or not, but we don't have a function to check if the schema itself is valid (without signature)

@tobiaslins
Copy link
Contributor

@willclarktech
Want to throw something in here.
What about using ajv or joi for validation?
Will be much simpler then what you did on #678

https://github.com/hapijs/joi
https://github.com/epoberezkin/ajv

Not sure if it makes sense, but what do you think?

@willclarktech
Copy link
Contributor

We'll revisit this for 1.1.0 and come up with a comprehensive solution for schema checks of all useful sorts. Thanks for the resources @tobiaslins, we'll check them out when we come back to this.

@willclarktech
Copy link
Contributor

willclarktech commented Jul 13, 2018

There's already enough in 1.1.0, we'll schedule this for 1.2.0. The plan is to use ajv.

@willclarktech
Copy link
Contributor

Closed in #734

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants