Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Show warning when passphrase is not recommended format #337

Closed
willclarktech opened this issue Nov 10, 2017 · 1 comment
Closed

Show warning when passphrase is not recommended format #337

willclarktech opened this issue Nov 10, 2017 · 1 comment
Labels
*medium 🌱 enhancement

Comments

@willclarktech
Copy link
Contributor

willclarktech commented Nov 10, 2017 •
edited
Loading

#328 (comment)

In line with this comment it would be nice to validate passphrase inputs (or not if a --no-verify flag is passed). The user should be given all the relevant error messages.

This should be done at the end of the getInputsFromSources util function.
@willclarktech willclarktech added this to the Version 0.4.0 milestone Nov 10, 2017
@willclarktech willclarktech mentioned this issue Nov 10, 2017
Merged
@willclarktech willclarktech removed this from the Version 1.0.0 milestone Feb 14, 2018
@willclarktech willclarktech added this to the Version 1.1.0 milestone Feb 21, 2018
@shuse2 shuse2 removed this from the Version 1.1.0 milestone May 30, 2018
@shuse2 shuse2 mentioned this issue Jul 30, 2018
Merged
@shuse2
Copy link
Contributor

shuse2 commented Oct 17, 2018

We should not reject the command but print the warning

@shuse2 shuse2 changed the title Validate passphrase inputs Show warning when passphrase is not recommended format Nov 1, 2018
@mitsuaki-u mitsuaki-u mentioned this issue Nov 8, 2018
Merged
shuse2 added a commit that referenced this issue Nov 9, 2018
@shuse2
Merge pull request #644 from LiskHQ/337-passphrase_validation
9efb897 
Display warning for passphrase format - Closes #337
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*medium 🌱 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shuse2 @toschdev @willclarktech @mitsuaki-u