This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Display warning for passphrase format - Closes #337 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
Nov 8, 2018
src/utils/input/index.js
Outdated
| error => error.code !== 'INVALID_MNEMONIC', | ||
| ); | ||
| uniquePassphraseErrors.forEach(error => | ||
| console.info(`Warning: ${error.message}`), |
There was a problem hiding this comment.
prefer not using the console
Validate right before executing the command?
There was a problem hiding this comment.
I mean return back the errors from the utils and handle it with this.print in each command?
src/utils/input/index.js
Outdated
| @@ -13,6 +13,7 @@ | |||
| * Removal or modification of this copyright notice is prohibited. | |||
| * | |||
| */ | |||
| import * as elements from 'lisk-elements'; | |||
There was a problem hiding this comment.
i think u can destruct here or not use *
shuse2
previously requested changes
Nov 8, 2018
src/utils/input/index.js
Outdated
| const errors = passphraseModule.validation | ||
| .getPassphraseValidationErrors(input) | ||
| .filter(error => error.message); | ||
| if (accumulator.length === 0) { |
There was a problem hiding this comment.
do we need this length check?
test/utils/input/index.js
Outdated
| passphrase: stdin, | ||
| }); | ||
| await getInputsFromSources(inputs); | ||
| expect(console.warn.getCall(0).args[0].trim()).to.equal( |
There was a problem hiding this comment.
calledWith doesn't work here?
shuse2
previously requested changes
Nov 9, 2018
shuse2
approved these changes
Nov 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
No warning when user inputs invalid mnemonic for passphrase.
How did I fix it?
Modified
getInputsFromSourcesto fetch warnings from elements.How to test it?
Enter invalid mnemonic passphrase for any command that requires passphrase input.
Review checklist