This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add signing function for non protocol message #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasKendziorra
requested review from
shuse2,
ManuGowda,
mjerkov,
AnanyaSshri and
sergeyshemyakov
and removed request for
mjerkov
AnanyaSshri
reviewed
Jul 26, 2023
AnanyaSshri
approved these changes
Jul 26, 2023
sergeyshemyakov
approved these changes
Jul 26, 2023
shuse2
approved these changes
Jul 26, 2023
shuse2
reviewed
Jul 26, 2023
| A non-protocol related message `message` can be signed by the function `signNonProtocolEd25519`. The resulting signature can be verified by `verifyNonProtocolEd25519`. This scheme should be used for the _sign message_ feature in Lisk Desktop. Note that the tag `MESSAGE_TAG_NON_PROTOCOL_MESSAGE` is defined in [LIP 0037](https://github.com/LiskHQ/lips/blob/main/proposals/lip-0037.md#message-tags-1). | ||
|
|
||
| ```python | ||
| def signNonProtocolEd25519(sk: bytes, message: bytes) -> bytes: |
There was a problem hiding this comment.
maybe not necessary to align, but for the SDK we have functions like
signMessageWithPrivateKey
verifyMessageWithPublicKey
so and it's used like ed.signMessageWithPrivateKey. I would prefer to keep those names
There was a problem hiding this comment.
I see the reason to keep the names in the SDK and it's fine for me. Would be good to haven some comments then. I'm also open to new names for the LIP as I'm not satisfied with them as well. But I didn't have a better idea. But I would like to avoid signMessageWithPrivateKey as it is really not descriptive.
There was a problem hiding this comment.
An alternative could be signOffchainDataEd25519.
|
Created corresponding issue on SDK: LiskArchive/lisk-sdk#8775 |
eniolam1000752
approved these changes
Jul 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427