Fix LIP0054 open issues #285
Conversation
| if terminatedOutboxAccount(trsParams.chainID) exists: | ||
| raise Exception("Terminated outbox account already exists.") | ||
|
|
||
| queryKey = STORE_PREFIX_INTEROPERABILITY + SUBSTORE_PREFIX_CHANNEL_DATA + sha256(getMainchainID()) | ||
| queryKey = STORE_PREFIX_INTEROPERABILITY + SUBSTORE_PREFIX_CHANNEL_DATA + sha256(OWN_CHAIN_ID) |
There was a problem hiding this comment.
BTW: we should make sure that we have a unit test where this verify function is called where OWN_CHAIN_ID != getMainchainID(). Otherwise, I'd be a bit afraid that the implementation would not be changed as sha256(getMainchainID()) should work for all other SKD 6 tests.
There was a problem hiding this comment.
good point, I have noted it down in the issue (LiskArchive/lisk-sdk#8254) on SDK
Co-authored-by: AndreasKendziorra <[email protected]>
| if terminatedOutboxAccount(trsParams.chainID) exists: | ||
| raise Exception("Terminated outbox account already exists.") | ||
|
|
||
| queryKey = STORE_PREFIX_INTEROPERABILITY + SUBSTORE_PREFIX_CHANNEL_DATA + sha256(getMainchainID()) | ||
| queryKey = STORE_PREFIX_INTEROPERABILITY + SUBSTORE_PREFIX_CHANNEL_DATA + sha256(OWN_CHAIN_ID) |
There was a problem hiding this comment.
good point, I have noted it down in the issue (LiskArchive/lisk-sdk#8254) on SDK
| @@ -161,7 +180,8 @@ stateRecoveryParams = { | |||
| "siblingHashes": { | |||
| "type": "array", | |||
| "items": { | |||
| "dataType": "bytes" | |||
| "dataType": "bytes", | |||
| "length": HASH_LENGTH | |||
There was a problem hiding this comment.
Just a small inconsistency but here you use 'length' but in the other params you are using 'minLength' and 'maxLength'.
| # Check that all query keys are pariwise distinct, | ||
| # meaning that we are not trying to recover the same entry twice. | ||
| if len(queryKeys) != len(set(queryKeys)): | ||
| raise Exception("Recovered store keys are not pairwise distinct.") |
There was a problem hiding this comment.
Can't we just say 'distinct' for simplicity
Closes #283.
createTerminatedStateAccountfunction to actually make use of the inputstateRoot