Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update Message Recovery Initialization Command #8254

Closed
Tracked by #7210
ishantiw opened this issue Mar 9, 2023 · 0 comments · Fixed by #8296
Closed
Tracked by #7210

Update Message Recovery Initialization Command #8254

ishantiw opened this issue Mar 9, 2023 · 0 comments · Fixed by #8296
Assignees
Labels
framework/module/interoperability Interoperability module
Milestone

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Mar 9, 2023

Description

Update Message Recovery Initialization Command based on LIP PR as per following changes

  • Update condition
# The commands fails if the chain is not terminated.
if terminatedStateAccount(trsParams.chainID) does not exist or terminatedStateAccount(trsParams.chainID).initialized == False:

to

# The command fails if the chain is not terminated.
    if terminatedStateAccount(trsParams.chainID) does not exist:
        raise Exception("Terminated state account not present.")
  • Update queryKey calculation to queryKey = STORE_PREFIX_INTEROPERABILITY + SUBSTORE_PREFIX_CHANNEL_DATA + sha256(OWN_CHAIN_ID). Make sure to add a unit test where OWN_CHAIN_ID != getMainchainID()

Acceptance Criteria

  • Should have new/updated unit test cases based on the update
  • All unit tests should pass

Additional Information

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework/module/interoperability Interoperability module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants