-
Notifications
You must be signed in to change notification settings - Fork 13
Add LIP: "Define new transaction schema" #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor details to be fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks all good. I just left a few comments.
I did not verify the appendix as I assume that has happened already by other reviewers before the publication.
Improving/adding links, fixing typos, names of constants. Addressed all comments of Alessandro, two of Jan's comments remain to be addressed.
not done yet
not finished yet
remain: Rationale and tests
Appendix not updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, also please update the appendx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small comment
No description provided.