Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add LIP: "Define new transaction schema" #155

Merged
merged 35 commits into from
Sep 1, 2022
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
6e50dd4
Add LIP
gkoumout Jun 21, 2022
73602c2
Add length property to json schema
gkoumout Jun 21, 2022
9646f04
Addressing comments
gkoumout Jun 23, 2022
3dfbba3
Started adding the functions
gkoumout Jun 28, 2022
df5f00c
minor changes
gkoumout Jul 5, 2022
acd5fde
Addressing Jan's comments
gkoumout Jul 6, 2022
d06ba2a
Change motivation, move to strings
gkoumout Aug 2, 2022
1799913
Update to lastest changes on names
gkoumout Aug 3, 2022
51c8bda
commit Jan'ssuggestion
gkoumout Aug 4, 2022
6980b7c
Add min max length for module/command names
gkoumout Aug 4, 2022
9d1ba57
update signature calculation function
gkoumout Aug 4, 2022
9a4f9fc
Update lip-define_new_transaction_schema.md
gkoumout Aug 4, 2022
f287f57
Add changes section compared to LIP28
gkoumout Aug 4, 2022
ef3b280
Apply suggestions from Ale's review
gkoumout Aug 5, 2022
5b529f9
update serialization/deserialization functions
gkoumout Aug 5, 2022
0936c7d
specify allowed characters in schema
gkoumout Aug 5, 2022
4b80161
fix regex
gkoumout Aug 5, 2022
917c9df
Address remaining review comments
janhack Aug 8, 2022
d0e2a40
Update allowed characters for command and module name
janhack Aug 8, 2022
e9ea30f
Add tbd to appendix
janhack Aug 8, 2022
496447c
add appendix
ricott1 Aug 12, 2022
b20a00b
Replace networkIdentifier by chainID
gkoumout Aug 22, 2022
ccfb89d
Update Appendix
gkoumout Aug 22, 2022
ed8d88f
update link to chainID
gkoumout Aug 22, 2022
a9eb81e
fix typo
gkoumout Aug 26, 2022
66a8722
fix typo
gkoumout Aug 26, 2022
5d94258
replace signMessage by signEdd25519
gkoumout Aug 26, 2022
217106f
fix typo
gkoumout Aug 26, 2022
d5b27e1
:nail_care: Apply standards
Sep 1, 2022
2e7b582
:pencil: Update header
Sep 1, 2022
8474aaf
:pencil: Assign number
Sep 1, 2022
1e11c71
:bookmark: Add to index
Sep 1, 2022
1b9b009
:pencil: Adjust number
Sep 1, 2022
b11ef11
Merge branch 'main' into add-LIP-Define-new-transaction-schema
Sep 1, 2022
93d0969
:pencil: Fix indent
Sep 1, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions proposals/lip-define_new_transaction_schema.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,12 @@ transactionSchema = {
"properties": {
"moduleID": {
"dataType": "bytes",
"length": MODULE_ID_LENGTH_BYTES,
"fieldNumber": 1
},
"commandID": {
"dataType": "bytes",
"length": COMMAND_ID_LENGTH_BYTES,
"fieldNumber": 2
},
"nonce": {
Expand All @@ -98,6 +100,7 @@ transactionSchema = {
},
"senderPublicKey": {
"dataType": "bytes",
"length": PUBLIC_KEY_LENGTH_BYTES,
ricott1 marked this conversation as resolved.
Show resolved Hide resolved
"fieldNumber": 5
},
"params": {
janhack marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -108,6 +111,7 @@ transactionSchema = {
"dataType": "array",
"items": {
"dataType": "bytes",
"length": SIGNATURE_LENGTH_BYTES
},
"fieldNumber": 7
}
Expand All @@ -120,10 +124,7 @@ transactionSchema = {

For a transaction `trs` to be valid, it must satisfy the following:
gkoumout marked this conversation as resolved.
Show resolved Hide resolved

* `trs.moduleID` is of length `MODULE_ID_LENGTH_BYTES`.
* `trs.commandID` is of length `COMMAND_ID_LENGTH_BYTES`.
* `trs.senderPublicKey` is of length `PUBLIC_KEY_LENGTH_BYTES`.
* all elements of `trs.signatures` are of length `SIGNATURE_LENGTH_BYTES`.

* `trs.params` is of length less than or equal to `MAX_PARAMS_SIZE_BYTES` .


Expand Down