Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix genesis block aggregate commit #9048

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Fix genesis block aggregate commit #9048

merged 4 commits into from
Sep 29, 2023

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Sep 27, 2023

What was the problem?

This PR resolves #9044

How was it solved?

  • Update getMaxRemovalHeight to be at least genesis height
  • Update genesis header aggregateCommit.height to be genesis height

How was it tested?

  • Update unit tests

@shuse2 shuse2 self-assigned this Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #9048 (0e77565) into release/6.0.0 (ef9e6be) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.0.0    #9048   +/-   ##
==============================================
  Coverage          83.53%   83.53%           
==============================================
  Files                603      603           
  Lines              22669    22669           
  Branches            3348     3348           
==============================================
  Hits               18937    18937           
  Misses              3732     3732
Files Coverage Δ
elements/lisk-chain/src/block_header.ts 73.13% <100.00%> (ø)
framework/src/engine/consensus/consensus.ts 82.72% <100.00%> (ø)
framework/src/genesis_block.ts 86.95% <ø> (ø)

@shuse2 shuse2 mentioned this pull request Sep 27, 2023
Merged
ishantiw
ishantiw approved these changes Sep 28, 2023
View reviewed changes
elements/lisk-chain/src/block_header.ts Outdated Show resolved Hide resolved
janhack
janhack approved these changes Sep 29, 2023
View reviewed changes
Copy link

@janhack janhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@shuse2 shuse2 enabled auto-merge (squash) September 29, 2023 08:02
@shuse2 shuse2 merged commit 321a376 into release/6.0.0 Sep 29, 2023
11 checks passed
@shuse2 shuse2 deleted the 9044-fix-aggregate-commit-height branch September 29, 2023 09:04
@shuse2 shuse2 mentioned this pull request Oct 6, 2023
Closed
shuse2 added a commit that referenced this pull request Oct 6, 2023
@shuse2
:arrow_back: Revert #9048
f6136e3
@shuse2 shuse2 mentioned this pull request Oct 6, 2023
Merged
shuse2 added a commit that referenced this pull request Oct 7, 2023
@shuse2
Revert #9048 to fix the testnet genesis block issue (#9071)
0d984bd 
:arrow_back: Revert #9048
shuse2 added a commit that referenced this pull request Oct 19, 2023
@shuse2
Revert ":arrow_back: Revert #9048"
684c1a4 
This reverts commit f6136e3.
shuse2 added a commit that referenced this pull request Oct 23, 2023
@shuse2 @ishantiw
Revert "Revert #9048" (#9107)
b2c85d3 
Revert ":arrow_back: Revert #9048"

This reverts commit f6136e3.

Co-authored-by: !shan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ishantiw ishantiw ishantiw approved these changes

@janhack janhack janhack approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuse2 @ishantiw @janhack