Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

TokenInteroperableMethod.recover validates storeValue #9029

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

has5aan
Copy link
Contributor

@has5aan has5aan commented Sep 21, 2023

What was the problem?

This PR resolves #9002

How was it solved?

Updated TokenInteroperableMethod.recover to validate storeValue against userStoreSchema.

How was it tested?

Implemented unit tests.

@has5aan has5aan self-assigned this Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #9029 (4cadcbf) into release/6.0.0 (923d839) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.0.0    #9029   +/-   ##
==============================================
  Coverage          83.54%   83.54%           
==============================================
  Files                603      603           
  Lines              22683    22685    +2     
  Branches            3352     3352           
==============================================
+ Hits               18950    18952    +2     
  Misses              3733     3733           
Files Changed Coverage
framework/src/modules/token/cc_method.ts 100.00%

Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me, but i think this needs to be fixed in 6.0 branch as well. can you rebase this to 6.0 ?

@has5aan has5aan changed the base branch from release/6.1.0 to release/6.0.0 September 22, 2023 06:47
@has5aan has5aan requested a review from shuse2 September 22, 2023 15:35
@shuse2 shuse2 merged commit 758ec0b into release/6.0.0 Sep 25, 2023
11 checks passed
@shuse2 shuse2 deleted the 9002-validate-recover-method branch September 25, 2023 11:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants