Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove collectionID as a data field from the create event of NFT module #9001

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

Incede
Copy link
Contributor

@Incede Incede commented Sep 18, 2023

What was the problem?

This PR resolves #8971

How was it solved?

Update as specified

How was it tested?

Updated unit test

@Incede Incede self-assigned this Sep 18, 2023
Copy link
Contributor

@mjerkov mjerkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note to correct the fieldNumber in createEventSchema.

framework/src/modules/nft/events/create.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #9001 (f1d0488) into release/6.1.0 (6615719) will increase coverage by 0.00%.
Report is 17 commits behind head on release/6.1.0.
The diff coverage is 97.82%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.1.0    #9001   +/-   ##
==============================================
  Coverage          84.36%   84.36%           
==============================================
  Files                650      651    +1     
  Lines              24031    24015   -16     
  Branches            3491     3493    +2     
==============================================
- Hits               20273    20260   -13     
+ Misses              3758     3755    -3     
Files Changed Coverage
elements/lisk-chain/src/state_store/state_store.ts ø
elements/lisk-chain/src/state_store/utils.ts ø
elements/lisk-cryptography/src/nacl/slow.ts ø
...amework/src/modules/nft/cc_commands/cc_transfer.ts ø
framework/src/modules/nft/commands/transfer.ts ø
...k/src/modules/nft/commands/transfer_cross_chain.ts ø
framework/src/modules/nft/schemas.ts ø
...k/src/modules/poa/commands/update_generator_key.ts ø
framework/src/modules/poa/schemas.ts ø
framework/src/modules/poa/stores/snapshot.ts ø
... and 40 more

@shuse2 shuse2 merged commit 53fa52f into release/6.1.0 Sep 21, 2023
11 checks passed
@shuse2 shuse2 deleted the 8971-update-schema branch September 21, 2023 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants