Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Incorrect MIN_SINT32 constant in lisk validator #8976

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Incede
Copy link
Contributor

@Incede Incede commented Sep 14, 2023

What was the problem?

This PR resolves #8975

How was it solved?

  • Update incorrect constant
  • Update incorrect comments

How was it tested?

Update unit test

@Incede Incede self-assigned this Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #8976 (53eb467) into release/6.1.0 (4f88fb8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.1.0    #8976   +/-   ##
==============================================
  Coverage          84.35%   84.35%           
==============================================
  Files                650      650           
  Lines              24033    24033           
  Branches            3492     3492           
==============================================
+ Hits               20273    20274    +1     
+ Misses              3760     3759    -1     
Files Changed Coverage
elements/lisk-validator/src/constants.ts 100.00%

@ishantiw ishantiw merged commit e3a31ab into release/6.1.0 Sep 14, 2023
11 checks passed
@ishantiw ishantiw deleted the 8975-incorrect-constant branch September 14, 2023 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants