This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update poa module schema validation and endpoint #8967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/6.1.0 #8967 +/- ##
==============================================
Coverage 84.35% 84.36%
==============================================
Files 650 650
Lines 24029 24022 -7
Branches 3491 3490 -1
==============================================
- Hits 20269 20265 -4
+ Misses 3760 3757 -3 |
ishantiw
reviewed
Sep 13, 2023
mitsuaki-u
changed the title
Phanco
approved these changes
Sep 14, 2023
mitsuaki-u
force-pushed
the
8944-poa-endpoint
branch
from
c0324fa
to
08196f9
Compare
Phanco
added a commit
that referenced
this pull request
Sep 14, 2023
Merged
ishantiw
suggested changes
Sep 14, 2023
framework/test/unit/modules/poa/commands/register_authority.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/poa/commands/update_generator_key.spec.ts
Outdated
Show resolved
Hide resolved
mitsuaki-u
force-pushed
the
8944-poa-endpoint
branch
from
08196f9
to
23f4a35
Compare
ishantiw
reviewed
Sep 15, 2023
framework/test/unit/modules/poa/commands/update_generator_key.spec.ts
Outdated
Show resolved
Hide resolved
ishantiw
approved these changes
Sep 18, 2023
ishantiw
added a commit
that referenced
this pull request
Sep 20, 2023
* Code improvements and remove shuffleValidatorList from PoA * Revert changes that has already been resolved in #8967 at update_generator_key --------- Co-authored-by: !shan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8944 and #8945, #8962 and #8965
How was it solved?
How was it tested?
Check tests