This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Method isNFTSupported incorrectly checks if the nft already exists #8835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/6917-implement-nft-module #8835 +/- ##
=====================================================================
- Coverage 83.97% 83.97% -0.01%
=====================================================================
Files 623 623
Lines 23278 23276 -2
Branches 3400 3400
=====================================================================
- Hits 19548 19545 -3
- Misses 3730 3731 +1
|
shuse2
approved these changes
Aug 10, 2023
Base automatically changed from
8831-owner
to
feature/6917-implement-nft-module
August 10, 2023 16:10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8832
How was it solved?
Remove the invalid check
How was it tested?
Updated unit test