Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

BFT weight mainchain registration #8794

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

has5aan
Copy link
Contributor

@has5aan has5aan commented Aug 1, 2023

What was the problem?

This PR resolves #8782

How was it solved?

Updates RegisterMainchainCommand.verify to throw if total BFT weight exceeds MAX_UINT64 after aggregating BFT weight of each validator.

How was it tested?

Verifying if existing tests are passing.

@has5aan has5aan self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #8794 (9e6e59f) into release/6.0.0 (c49607a) will increase coverage by 0.05%.
Report is 111 commits behind head on release/6.0.0.
The diff coverage is 84.90%.

❗ Current head 9e6e59f differs from pull request most recent head ac9588a. Consider uploading reports for the commit ac9588a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #8794      +/-   ##
=================================================
+ Coverage          83.27%   83.33%   +0.05%     
=================================================
  Files                593      594       +1     
  Lines              22254    22329      +75     
  Branches            3252     3292      +40     
=================================================
+ Hits               18532    18607      +75     
  Misses              3722     3722              
Files Changed Coverage Δ
commander/src/base.ts 65.38% <0.00%> (-24.09%) ⬇️
commander/src/utils/genesis_creation.ts 69.23% <ø> (+38.46%) ⬆️
commander/test/helpers/transactions.ts 96.00% <ø> (-0.16%) ⬇️
elements/lisk-api-client/src/codec.ts 67.51% <ø> (ø)
elements/lisk-chain/src/schema.ts 100.00% <ø> (ø)
elements/lisk-p2p/src/schema.ts 100.00% <ø> (ø)
elements/lisk-transaction-pool/src/index.ts 0.00% <0.00%> (ø)
...n-connector-plugin/src/active_validators_update.ts 80.35% <0.00%> (ø)
...sk-framework-chain-connector-plugin/src/schemas.ts 100.00% <ø> (ø)
...k-framework-dashboard-plugin/src/plugin/schemas.ts 100.00% <ø> (ø)
... and 56 more

... and 78 files with indirect coverage changes

@shuse2 shuse2 enabled auto-merge (squash) August 3, 2023 09:09
@shuse2 shuse2 merged commit 3f6e3db into release/6.0.0 Aug 3, 2023
8 checks passed
@shuse2 shuse2 deleted the 8782-bftWeight-mainchain-registration branch August 3, 2023 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants