Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix terminate chain method #8740

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Conversation

Phanco
Copy link
Contributor

@Phanco Phanco commented Jul 13, 2023

What was the problem?

This PR resolves #8603

How was it solved?

Use .has to check terminatedAccount

How was it tested?

Unit tests updated

@Phanco Phanco self-assigned this Jul 13, 2023
@Phanco Phanco marked this pull request as ready for review July 13, 2023 21:45
Copy link
Contributor

@sitetester sitetester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus point:

{
	get: jest.fn(),
	set: jest.fn(),
	has: jest.fn(),
};

These repeated mocking calls don't look so nice on page, so can replace with getStoreMock() like this

const getStoreMock = () => ({
	get: jest.fn(),
	set: jest.fn(),
	has: jest.fn(),
});
const chainAccountStoreMock = getStoreMock(); // Example change

Copy link
Contributor

@sitetester sitetester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback submitted

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #8740 (3afd481) into release/6.0.0 (e816bf8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3afd481 differs from pull request most recent head 6f45c14. Consider uploading reports for the commit 6f45c14 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.0.0    #8740   +/-   ##
==============================================
  Coverage          83.30%   83.30%           
==============================================
  Files                593      593           
  Lines              22282    22294   +12     
  Branches            3288     3292    +4     
==============================================
+ Hits               18561    18572   +11     
- Misses              3721     3722    +1     
Impacted Files Coverage Δ
...s/interoperability/base_interoperability_method.ts 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@ishantiw ishantiw requested a review from sitetester July 21, 2023 07:57
@ishantiw ishantiw enabled auto-merge (squash) July 21, 2023 11:30
@ishantiw ishantiw merged commit 4faa22c into release/6.0.0 Jul 21, 2023
8 checks passed
@ishantiw ishantiw deleted the 8603-fix-terminate-chain-method branch July 21, 2023 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants