This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix-terminate-chain-method
sitetester
reviewed
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonus point:
{
get: jest.fn(),
set: jest.fn(),
has: jest.fn(),
};
These repeated mocking calls don't look so nice on page, so can replace with getStoreMock()
like this
const getStoreMock = () => ({
get: jest.fn(),
set: jest.fn(),
has: jest.fn(),
});
const chainAccountStoreMock = getStoreMock(); // Example change
sitetester
suggested changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback submitted
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.0.0 #8740 +/- ##
==============================================
Coverage 83.30% 83.30%
==============================================
Files 593 593
Lines 22282 22294 +12
Branches 3288 3292 +4
==============================================
+ Hits 18561 18572 +11
- Misses 3721 3722 +1
|
sitetester
approved these changes
Jul 21, 2023
mitsuaki-u
approved these changes
Jul 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8603
How was it solved?
Use
.has
to check terminatedAccountHow was it tested?
Unit tests updated