Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix length requirement and dataType on getChainAccountRequestSchema #8627

Merged
merged 5 commits into from
Jun 23, 2023

Conversation

Phanco
Copy link
Contributor

@Phanco Phanco commented Jun 19, 2023

What was the problem?

This PR resolves #8604

How was it solved?

How was it tested?

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #8627 (7ce0d6c) into release/6.0.0 (cab45dc) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 7ce0d6c differs from pull request most recent head eab46ae. Consider uploading reports for the commit eab46ae to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #8627      +/-   ##
=================================================
- Coverage          83.24%   83.23%   -0.02%     
=================================================
  Files                593      593              
  Lines              22255    22245      -10     
  Branches            3289     3282       -7     
=================================================
- Hits               18526    18515      -11     
- Misses              3729     3730       +1     
Impacted Files Coverage Δ
framework/src/modules/interoperability/schemas.ts 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

@Phanco Phanco changed the base branch from development to release/6.0.0 June 21, 2023 08:50
@Phanco Phanco force-pushed the 8604-fix-get-chain-account-request-schema branch from a1670e6 to 4ecdcb4 Compare June 21, 2023 08:54
@Phanco Phanco marked this pull request as ready for review June 21, 2023 09:05
@Phanco Phanco requested a review from ishantiw June 23, 2023 09:15
@ishantiw ishantiw enabled auto-merge (squash) June 23, 2023 13:20
@ishantiw ishantiw merged commit c8e7558 into release/6.0.0 Jun 23, 2023
@ishantiw ishantiw deleted the 8604-fix-get-chain-account-request-schema branch June 23, 2023 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chain ID length not validated in interoperability endpoints
3 participants