Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement methods for NFT module #8590

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

Incede
Copy link
Contributor

@Incede Incede commented Jun 13, 2023

What was the problem?

This PR resolves #8543 #8544 #8585 #8586

How was it solved?

  • Implement methods transfer and transferCrossChain as specified
  • Resolve circular dependency by adding interface
  • Register & init commands in module

How was it tested?

Added unit tests

@Incede Incede requested review from mjerkov and has5aan June 13, 2023 21:00
@Incede Incede self-assigned this Jun 13, 2023
Copy link
Contributor

@mjerkov mjerkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I left just two comments about the missing case in transferCrossChain verification and related unit test.

framework/src/modules/nft/method.ts Show resolved Hide resolved
@Incede Incede requested a review from mjerkov June 14, 2023 22:42
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #8590 (c4dc4ae) into feature/6917-implement-nft-module (13bde5c) will increase coverage by 0.03%.
The diff coverage is 89.47%.

Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/6917-implement-nft-module    #8590      +/-   ##
=====================================================================
+ Coverage                              83.65%   83.68%   +0.03%     
=====================================================================
  Files                                    623      623              
  Lines                                  22936    23004      +68     
  Branches                                3323     3334      +11     
=====================================================================
+ Hits                                   19188    19252      +64     
- Misses                                  3748     3752       +4     
Impacted Files Coverage Δ
framework/src/modules/nft/internal_method.ts 96.61% <ø> (ø)
framework/src/modules/nft/schemas.ts 100.00% <ø> (ø)
framework/src/modules/nft/events/recover.ts 55.55% <33.33%> (-15.88%) ⬇️
framework/src/modules/nft/events/set_attributes.ts 55.55% <33.33%> (-15.88%) ⬇️
framework/src/modules/nft/module.ts 86.76% <80.00%> (+1.51%) ⬆️
framework/src/modules/nft/method.ts 99.33% <96.42%> (-0.67%) ⬇️
framework/src/modules/nft/constants.ts 100.00% <100.00%> (ø)
...ork/src/modules/nft/events/transfer_cross_chain.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Incede Incede merged commit b21584f into feature/6917-implement-nft-module Jun 15, 2023
@Incede Incede deleted the 8543-methods branch June 15, 2023 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants