Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Lock and Unlock method for NFT #8561

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

has5aan
Copy link
Contributor

@has5aan has5aan commented Jun 7, 2023

What was the problem?

This PR resolves #8540 & #8541

How was it solved?

Implemented Lock and Unlock method as per LIP0052.

How was it tested?

Implemented unit tests.

@has5aan has5aan requested review from Incede and mjerkov June 7, 2023 14:16
@has5aan has5aan self-assigned this Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #8561 (de66f9e) into feature/6917-implement-nft-module (d742596) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/6917-implement-nft-module    #8561      +/-   ##
=====================================================================
+ Coverage                              83.47%   83.51%   +0.03%     
=====================================================================
  Files                                    623      623              
  Lines                                  22800    22843      +43     
  Branches                                3297     3304       +7     
=====================================================================
+ Hits                                   19033    19078      +45     
+ Misses                                  3767     3765       -2     
Impacted Files Coverage Δ
framework/src/modules/nft/events/lock.ts 100.00% <100.00%> (+28.57%) ⬆️
framework/src/modules/nft/method.ts 100.00% <100.00%> (ø)

Copy link
Contributor

@mjerkov mjerkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only some minor comments regarding the unlocking of escrowed NFT.

framework/src/modules/nft/method.ts Outdated Show resolved Hide resolved
framework/src/modules/nft/method.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/nft/method.spec.ts Outdated Show resolved Hide resolved
framework/src/modules/nft/method.ts Outdated Show resolved Hide resolved
framework/src/modules/nft/method.ts Outdated Show resolved Hide resolved
@mjerkov mjerkov self-requested a review June 9, 2023 08:32
Copy link
Contributor

@mjerkov mjerkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side

framework/src/modules/nft/method.ts Show resolved Hide resolved
@has5aan has5aan merged commit be7e6fb into feature/6917-implement-nft-module Jun 9, 2023
@has5aan has5aan deleted the 8540_8541_lock_unlock branch June 9, 2023 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants