This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Lock and Unlock method for NFT #8561
Merged
has5aan
merged 5 commits into
feature/6917-implement-nft-module
from
8540_8541_lock_unlock
Jun 9, 2023
Merged
Lock and Unlock method for NFT #8561
has5aan
merged 5 commits into
feature/6917-implement-nft-module
from
8540_8541_lock_unlock
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/6917-implement-nft-module #8561 +/- ##
=====================================================================
+ Coverage 83.47% 83.51% +0.03%
=====================================================================
Files 623 623
Lines 22800 22843 +43
Branches 3297 3304 +7
=====================================================================
+ Hits 19033 19078 +45
+ Misses 3767 3765 -2
|
mjerkov
suggested changes
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only some minor comments regarding the unlocking of escrowed NFT.
Incede
reviewed
Jun 9, 2023
Incede
suggested changes
Jun 9, 2023
mjerkov
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side
has5aan
force-pushed
the
8540_8541_lock_unlock
branch
from
June 9, 2023 09:39
432adc5
to
de66f9e
Compare
Incede
approved these changes
Jun 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8540 & #8541
How was it solved?
Implemented Lock and Unlock method as per LIP0052.
How was it tested?
Implemented unit tests.