-
Notifications
You must be signed in to change notification settings - Fork 454
Implement cross chain command for cross chain transfer for NFT module #8535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good, I left only two comments for tests un cc_transfer.spec.ts
. I would also add the getNewAttributes
as defined in LIP for the reasons described in the Rationale:
When an NFT is sent to another chain, the attributes properties of the NFT can be modified according to specifications set on the receiving chain. When the NFT is received back on its native chain, the returned modified attributes are disregarded and the original attributes are restored, as currently defined by getNewAttributes function. If needed, custom modules can implement a more fine-grained approach towards the attributes that are modified cross-chain.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/6917-implement-nft-module #8535 +/- ##
=====================================================================
+ Coverage 83.31% 83.41% +0.09%
=====================================================================
Files 621 622 +1
Lines 22604 22719 +115
Branches 3268 3287 +19
=====================================================================
+ Hits 18833 18951 +118
+ Misses 3771 3768 -3
|
What was the problem?
This PR resolves #8395 #8494 #8536
How was it solved?
Implement as specified
How was it tested?
Added unit tests