This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
transferCrossChainInternal Method for NFT Module #8520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has5aan
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/6917-implement-nft-module #8520 +/- ##
=====================================================================
+ Coverage 83.23% 83.32% +0.08%
=====================================================================
Files 621 621
Lines 22544 22604 +60
Branches 3258 3268 +10
=====================================================================
+ Hits 18765 18834 +69
+ Misses 3779 3770 -9
|
has5aan
force-pushed
the
8493_nft_transferCrossChainInternal
branch
from
e0f76ce
to
720548b
Compare
Base automatically changed from
8393_nft_transfer_command
to
feature/6917-implement-nft-module
June 1, 2023 14:46
has5aan
force-pushed
the
8493_nft_transferCrossChainInternal
branch
from
720548b
to
e78c475
Compare
mjerkov
reviewed
Jun 2, 2023
Incede
suggested changes
Jun 2, 2023
Incede
suggested changes
Jun 7, 2023
Incede
approved these changes
Jun 7, 2023
Co-authored-by: Incede <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8493 #8491
How was it solved?
Implements
InternalMethod.transferCrossChainInternalHow was it tested?
Implemented unit tests.