Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix event byte overflow #8515

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Fix event byte overflow #8515

merged 4 commits into from
Jun 5, 2023

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented May 31, 2023

What was the problem?

This PR resolves #8477

How was it solved?

  • Update the shift to result in unsigned integer

How was it tested?

  • Added test for min and max value

@shuse2 shuse2 requested review from mosmartin and ricott1 May 31, 2023 10:05
@shuse2 shuse2 self-assigned this May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #8515 (ef9ec49) into release/6.0.0 (c49607a) will increase coverage by 0.06%.
The diff coverage is 88.06%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #8515      +/-   ##
=================================================
+ Coverage          83.27%   83.34%   +0.06%     
=================================================
  Files                593      593              
  Lines              22254    22335      +81     
  Branches            3252     3277      +25     
=================================================
+ Hits               18532    18614      +82     
+ Misses              3722     3721       -1     
Impacted Files Coverage Δ
commander/src/utils/genesis_creation.ts 69.23% <ø> (+38.46%) ⬆️
elements/lisk-chain/src/schema.ts 100.00% <ø> (ø)
...n-connector-plugin/src/active_validators_update.ts 80.35% <0.00%> (ø)
...lisk-framework-faucet-plugin/src/plugin/schemas.ts 100.00% <ø> (ø)
framework/src/controller/channels/ipc_channel.ts 7.75% <0.00%> (ø)
framework/src/controller/child_process_loader.ts 0.00% <0.00%> (ø)
framework/src/modules/pos/schemas.ts 100.00% <ø> (ø)
framework/src/schema/application_config_schema.ts 100.00% <ø> (ø)
framework/src/testing/fixtures/config.ts 41.66% <ø> (ø)
framework/src/types.ts 100.00% <ø> (ø)
... and 43 more

Copy link
Contributor

@ricott1 ricott1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add failing tests

@shuse2 shuse2 enabled auto-merge (squash) June 5, 2023 12:10
@shuse2 shuse2 merged commit f5b8925 into release/6.0.0 Jun 5, 2023
@shuse2 shuse2 deleted the 8477-fix-event-index branch June 5, 2023 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants