Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Name length check is missing from the validator registration command #8434

Merged
merged 2 commits into from
May 12, 2023

Conversation

Incede
Copy link
Contributor

@Incede Incede commented May 8, 2023

What was the problem?

This PR resolves #8407

How was it solved?

Updated schema to include min and max limits for name length

How was it tested?

Added unit tests

@Incede Incede requested review from shuse2 and mosmartin May 8, 2023 18:10
@Incede Incede self-assigned this May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #8434 (9a03651) into release/6.0.0 (caf76c1) will not change coverage.
The diff coverage is n/a.

❗ Current head 9a03651 differs from pull request most recent head 4f6794c. Consider uploading reports for the commit 4f6794c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.0.0    #8434   +/-   ##
==============================================
  Coverage          83.29%   83.29%           
==============================================
  Files                593      593           
  Lines              22255    22255           
  Branches            3253     3253           
==============================================
  Hits               18538    18538           
  Misses              3717     3717           
Impacted Files Coverage Δ
framework/src/modules/pos/schemas.ts 100.00% <ø> (ø)

@Incede Incede requested review from has5aan and removed request for mosmartin May 11, 2023 08:41
@shuse2 shuse2 enabled auto-merge (squash) May 12, 2023 07:17
@shuse2 shuse2 merged commit 8d924b1 into release/6.0.0 May 12, 2023
@shuse2 shuse2 deleted the 8407-missing-check branch May 12, 2023 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants