Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Used hash onion parameters count & 'height' not updated if imported from another node and block height is less than 'height' #8429

Merged
merged 3 commits into from
May 15, 2023

Conversation

Incede
Copy link
Contributor

@Incede Incede commented May 6, 2023

What was the problem?

This PR resolves #8369

How was it solved?

Cleanup other entries in used hash onion array if there is new entry with count zero which was not present before

How was it tested?

  • Tested manually following the steps described in the issue
  • Added 3 new unit tests for cases when used hash onion height is less, equal and greater to the current block height
  • Unrelated: Merged duplicate unit test

@Incede Incede self-assigned this May 6, 2023
@Incede Incede requested review from shuse2 and bobanm May 6, 2023 10:32
@Incede Incede added this to the Sprint 94 milestone May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #8429 (9778678) into release/6.0.0 (b77cba1) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 9778678 differs from pull request most recent head e90c96c. Consider uploading reports for the commit e90c96c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #8429      +/-   ##
=================================================
- Coverage          83.33%   83.30%   -0.04%     
=================================================
  Files                593      593              
  Lines              22272    22259      -13     
  Branches            3256     3254       -2     
=================================================
- Hits               18560    18542      -18     
- Misses              3712     3717       +5     
Impacted Files Coverage Δ
...work/src/modules/random/stores/used_hash_onions.ts 84.09% <100.00%> (+1.59%) ⬆️

... and 7 files with indirect coverage changes

@shuse2 shuse2 removed this from the Sprint 94 milestone May 8, 2023
@Incede Incede changed the base branch from development to release/6.0.0 May 8, 2023 17:21
@Incede Incede requested a review from bobanm May 10, 2023 11:02
@shuse2 shuse2 enabled auto-merge (squash) May 15, 2023 15:34
@shuse2 shuse2 merged commit 223a084 into release/6.0.0 May 15, 2023
@shuse2 shuse2 deleted the 8369-hash-onion branch May 15, 2023 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants