Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update banning log to be more clear #8292

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Mar 22, 2023

What was the problem?

This PR resolves #8282

How was it solved?

  • Update the log to be more clear on applying penalty

How was it tested?

N/A

@shuse2 shuse2 requested review from bobanm and mosmartin March 22, 2023 08:17
@shuse2 shuse2 self-assigned this Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #8292 (ef2a416) into development (6f821fb) will increase coverage by 0.00%.
The diff coverage is 42.85%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #8292   +/-   ##
============================================
  Coverage        83.14%   83.14%           
============================================
  Files              590      590           
  Lines            21892    21894    +2     
  Branches          3206     3206           
============================================
+ Hits             18202    18204    +2     
  Misses            3690     3690           
Impacted Files Coverage Δ
framework/src/engine/engine.ts 73.02% <ø> (ø)
framework/src/engine/legacy/network_endpoint.ts 91.42% <ø> (ø)
framework/src/engine/network/network.ts 54.38% <0.00%> (ø)
framework/src/engine/generator/network_endpoint.ts 57.27% <33.33%> (ø)
framework/src/engine/consensus/network_endpoint.ts 93.82% <50.00%> (ø)
...ramework/src/engine/legacy/legacy_chain_handler.ts 79.76% <50.00%> (-0.73%) ⬇️
framework/src/engine/consensus/consensus.ts 80.61% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@mosmartin mosmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shuse2 shuse2 requested a review from bobanm March 22, 2023 11:10
@shuse2 shuse2 merged commit 762b95c into development Mar 22, 2023
@shuse2 shuse2 deleted the 8282-update-banning-log branch March 22, 2023 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add log on the place it applies penalty
3 participants