This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Fix crashing the node when failing on execution or generation #8203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
commented
Mar 1, 2023
shuse2
commented
Mar 1, 2023
shuse2
force-pushed
the
8172-fix_sync_fail
branch
from
March 1, 2023 16:31
357e929
to
aa8621e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #8203 +/- ##
===============================================
- Coverage 82.89% 82.86% -0.03%
===============================================
Files 578 578
Lines 21154 21158 +4
Branches 3082 3092 +10
===============================================
- Hits 17535 17532 -3
- Misses 3619 3626 +7
|
bobanm
suggested changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good 👍🏻
I made only a few minor grammar remarks.
Co-authored-by: Boban Milošević <[email protected]>
bobanm
approved these changes
Mar 2, 2023
has5aan
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8172
How was it solved?
this seems to happen if block is received while generating a block.
How was it tested?