Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update MainchainCrossChainUpdate command execute function based on LIP0053 update #8030

Merged

Conversation

sitetester
Copy link
Contributor

@sitetester sitetester commented Jan 17, 2023

What was the problem?

This PR resolves #8017 #8018

How was it solved?

Mainly base_cross_chain_update_command.ts::executeCommon part is updated

How was it tested?

@sitetester sitetester self-assigned this Jan 17, 2023
@sitetester sitetester force-pushed the 8017-update-mainchainCrossChainUpdate-command-execute branch from 8f44d57 to 5556a62 Compare January 19, 2023 13:52
@sitetester sitetester changed the base branch from development to 8014-update-validator January 19, 2023 13:55
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #8030 (b967de8) into development (9c558f2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8030      +/-   ##
===============================================
+ Coverage        82.56%   82.58%   +0.01%     
===============================================
  Files              578      578              
  Lines            20986    21000      +14     
  Branches          3047     3047              
===============================================
+ Hits             17327    17342      +15     
+ Misses            3659     3658       -1     
Impacted Files Coverage Δ
...rability/base_interoperability_internal_methods.ts 89.14% <ø> (ø)
...c/modules/interoperability/events/ccm_processed.ts 100.00% <ø> (ø)
...nteroperability/base_cross_chain_update_command.ts 98.78% <100.00%> (+0.08%) ⬆️
...ramework/src/modules/interoperability/constants.ts 100.00% <100.00%> (ø)
...in/commands/submit_mainchain_cross_chain_update.ts 96.59% <100.00%> (+0.03%) ⬆️
...in/commands/submit_sidechain_cross_chain_update.ts 97.36% <100.00%> (+0.07%) ⬆️
elements/lisk-p2p/src/utils/select.ts 95.00% <0.00%> (+1.25%) ⬆️

Base automatically changed from 8014-update-validator to development January 19, 2023 14:41
@sitetester sitetester force-pushed the 8017-update-mainchainCrossChainUpdate-command-execute branch from 5556a62 to a8d724b Compare January 19, 2023 18:46
@sitetester sitetester marked this pull request as ready for review January 20, 2023 17:25
@sitetester sitetester changed the base branch from development to 7436-temp January 20, 2023 17:46
@sitetester sitetester changed the base branch from 7436-temp to development January 20, 2023 17:47
@ishantiw ishantiw requested a review from shuse2 January 23, 2023 11:57
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor comments related to TypeDoc but we can keep in mind for future PRs

@shuse2 shuse2 enabled auto-merge (squash) January 23, 2023 13:54
@shuse2 shuse2 merged commit 109f81c into development Jan 23, 2023
@shuse2 shuse2 deleted the 8017-update-mainchainCrossChainUpdate-command-execute branch January 23, 2023 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MainchainCrossChainUpdate command execute function based on LIP0053 update
3 participants