This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Update MainchainCrossChainUpdate command execute function based on LIP0053 update #8030
Merged
shuse2
merged 17 commits into
development
from
8017-update-mainchainCrossChainUpdate-command-execute
Jan 23, 2023
Merged
Update MainchainCrossChainUpdate command execute function based on LIP0053 update #8030
shuse2
merged 17 commits into
development
from
8017-update-mainchainCrossChainUpdate-command-execute
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitetester
force-pushed
the
8017-update-mainchainCrossChainUpdate-command-execute
branch
from
January 19, 2023 13:52
8f44d57
to
5556a62
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #8030 +/- ##
===============================================
+ Coverage 82.56% 82.58% +0.01%
===============================================
Files 578 578
Lines 20986 21000 +14
Branches 3047 3047
===============================================
+ Hits 17327 17342 +15
+ Misses 3659 3658 -1
|
sitetester
force-pushed
the
8017-update-mainchainCrossChainUpdate-command-execute
branch
from
January 19, 2023 18:46
5556a62
to
a8d724b
Compare
ishantiw
suggested changes
Jan 22, 2023
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
shuse2
suggested changes
Jan 23, 2023
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
shuse2
approved these changes
Jan 23, 2023
ishantiw
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of minor comments related to TypeDoc but we can keep in mind for future PRs
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Show resolved
Hide resolved
shuse2
deleted the
8017-update-mainchainCrossChainUpdate-command-execute
branch
January 23, 2023 14:39
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8017 #8018
How was it solved?
Mainly base_cross_chain_update_command.ts::executeCommon part is updated
How was it tested?