Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix generator enable/disable commands #7855

Merged
merged 12 commits into from
Dec 10, 2022
Merged

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Dec 4, 2022

What was the problem?

This PR resolves #7783

How was it solved?

  • Revert generator enable/disable command to have --use-status-value
    • Move height/max-height-generated/max-height-prevoted as flag
  • Revert temporally lisk-db version to the previous version because it leaves locks value Closing DB leaves the database locked lisk-db#78
  • Fix to pass keypairs from generator to endpoint
  • Remove keypair when setting new key

How was it tested?

  1. clean rm -rf ~/.lisk/pos-mainchain
  2. encrypt keys ./bin/run keys:encrypt -f ./config/default/dev-validators.json
  3. import new keys ./bin/run keys:import -f config/default/dev-validators.json
  4. enable block generation ./bin/run generator:enable lsk2xxvfxaqpm42wr9reokucegh3quypqg9w9aqfo --height=0 --max-height-prevoted=0 --max-height-generated=0
  5. check block is generated (wait for 1 round)
  6. check status ./bin/run generator:status --pretty

- Add codecov integration
- Add github actions to run CI including codecov
- Introduce NX for CI optimization
@shuse2 shuse2 requested review from bobanm and has5aan December 4, 2022 14:42
@shuse2 shuse2 self-assigned this Dec 4, 2022
@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Merging #7855 (ee54f99) into development (c29aa93) will increase coverage by 0.00%.
The diff coverage is 94.64%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7855   +/-   ##
============================================
  Coverage        82.11%   82.11%           
============================================
  Files              578      578           
  Lines            20893    20902    +9     
  Branches          3029     3027    -2     
============================================
+ Hits             17156    17164    +8     
- Misses            3737     3738    +1     
Impacted Files Coverage Δ
framework/src/engine/generator/generator.ts 82.45% <ø> (ø)
...er/src/bootstrapping/commands/generator/disable.ts 92.85% <91.66%> (-7.15%) ⬇️
...der/src/bootstrapping/commands/generator/enable.ts 93.33% <92.85%> (-6.67%) ⬇️
...ander/src/bootstrapping/commands/base_generator.ts 100.00% <100.00%> (ø)
...der/src/bootstrapping/commands/generator/import.ts 92.85% <100.00%> (ø)
framework/src/engine/generator/endpoint.ts 97.32% <100.00%> (+0.07%) ⬆️
elements/lisk-p2p/src/utils/select.ts 93.75% <0.00%> (ø)

Base automatically changed from 7110-update-code-cov to development December 6, 2022 09:17
@shuse2 shuse2 linked an issue Dec 6, 2022 that may be closed by this pull request
@shuse2 shuse2 requested a review from bobanm December 9, 2022 14:56
@shuse2 shuse2 requested a review from bobanm December 9, 2022 21:06
@shuse2 shuse2 merged commit 009bdd8 into development Dec 10, 2022
@shuse2 shuse2 deleted the 7783-fix_block_generate_cmd branch December 10, 2022 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generator command not enabling block generation
3 participants