Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update sidechain ccu command #7787

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Update sidechain ccu command #7787

merged 5 commits into from
Nov 22, 2022

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Nov 16, 2022

What was the problem?

This PR resolves #7725

How was it solved?

  • Refactor mainchain CCU command and move common logic to base class
  • Update sidechain CCU command

How was it tested?

  • Update sidechain CCU command test
  • Refactor mainchain CCU command test

@shuse2 shuse2 self-assigned this Nov 16, 2022
ishantiw
ishantiw reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, besides a minor comment and comments on related base PR #7786

framework/test/unit/modules/interoperability/sidechain/commands/cc_update.spec.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 force-pushed the 7725-update_sidechain_ccu branch 2 times, most recently from 78c87d8 to bc7928b Compare November 17, 2022 20:09
@shuse2 shuse2 requested a review from ishantiw November 17, 2022 20:09
Base automatically changed from 7724-update_mainchain_ccu to feature/7211-interop-module-updates November 21, 2022 21:31
@ishantiw ishantiw merged commit aa4c2d0 into feature/7211-interop-module-updates Nov 22, 2022
@ishantiw ishantiw deleted the 7725-update_sidechain_ccu branch November 22, 2022 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ishantiw ishantiw ishantiw approved these changes

@mitsuaki-u mitsuaki-u mitsuaki-u approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuse2 @ishantiw @mitsuaki-u