Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update verifyCertificate and verifyCertificateSignatre methods #7767

Merged

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Nov 10, 2022

What was the problem?

This PR resolves #7687 and resolves #7688

How was it solved?

  • Move verifyCertificateSignature to internalMethod and update per LIP
  • Add verifyCertificate to internalMethod per LIP

How was it tested?

  • Add unit tests to cover all the cases

@shuse2 shuse2 self-assigned this Nov 10, 2022
Base automatically changed from 7520-refactor_constants to feature/7211-interop-module-updates November 10, 2022 16:27
@shuse2 shuse2 force-pushed the 7687-update_verify_certificate branch from eb296bf to 304d116 Compare November 10, 2022 16:56
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, a minor comment though

@shuse2 shuse2 enabled auto-merge (squash) November 15, 2022 11:45
@shuse2 shuse2 merged commit 5dffd21 into feature/7211-interop-module-updates Nov 15, 2022
@shuse2 shuse2 deleted the 7687-update_verify_certificate branch November 15, 2022 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants