Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update DPoS endpoints #7732

Merged
merged 6 commits into from
Nov 7, 2022
Merged

Update DPoS endpoints #7732

merged 6 commits into from
Nov 7, 2022

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Nov 3, 2022

What was the problem?

This PR resolves #7673

How was it solved?

  • Update TokenIDDPoS to GovernanceTokenID to be consistent with endpoint.
  • Fix GenvernanceTokenID to be default to first native token
  • Add metadata for new endpoints and missing endpoints
  • Add endpoints defined in the issue

How was it tested?

  • Add tests for the new endpoints

@shuse2 shuse2 requested review from Incede and has5aan November 3, 2022 13:00
@shuse2 shuse2 self-assigned this Nov 3, 2022
@shuse2 shuse2 requested review from mosmartin and removed request for Incede November 3, 2022 13:34
mosmartin
mosmartin approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@mosmartin mosmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endpoints look good 🚀

mosmartin
mosmartin approved these changes Nov 4, 2022 •
edited
Loading
View reviewed changes
@shuse2 shuse2 requested a review from has5aan November 5, 2022 09:37
@shuse2 shuse2 merged commit d197893 into feature/7622-update-dpos-module Nov 7, 2022
@shuse2 shuse2 deleted the 7673-update_dpos_endpoint branch November 7, 2022 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mosmartin mosmartin mosmartin approved these changes

@has5aan has5aan has5aan approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuse2 @mosmartin @has5aan