This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Update send method of Interoperability Store - Closes #7562 #7682
Merged
ishantiw
merged 5 commits into
feature/7211-interop-module-updates
from
7562-update-send-func
Oct 28, 2022
Merged
Update send method of Interoperability Store - Closes #7562 #7682
ishantiw
merged 5 commits into
feature/7211-interop-module-updates
from
7562-update-send-func
Oct 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
force-pushed
the
7562-update-send-func
branch
from
October 24, 2022 09:07
b4ecaa4
to
fd28a5d
Compare
sitetester
suggested changes
Oct 24, 2022
Are we logging this event upon encode failure ? |
Phanco
approved these changes
Oct 26, 2022
This was referenced Oct 26, 2022
ishantiw
force-pushed
the
7562-update-send-func
branch
from
October 28, 2022 09:19
b30ae71
to
2ebc61c
Compare
sitetester
approved these changes
Oct 28, 2022
ishantiw
force-pushed
the
7562-update-send-func
branch
from
October 28, 2022 10:21
2ebc61c
to
5ff5b4e
Compare
ishantiw
added a commit
that referenced
this pull request
Nov 14, 2022
This PR resolves #7562 - Update send function based on updated LIP https://github.com/LiskHQ/lips/blob/main/proposals/lip-0045.md#sendinternal `npm run test`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7562
How was it solved?
♻️ Update send method of interoperability module Closes #7562
How was it tested?
npm run test