Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update send method of Interoperability Store - Closes #7562 #7682

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Update send method of Interoperability Store - Closes #7562 #7682

merged 5 commits into from
Oct 28, 2022

Conversation

ishantiw
Copy link
Contributor

What was the problem?

This PR resolves #7562

How was it solved?

♻️ Update send method of interoperability module Closes #7562

How was it tested?

npm run test

@ishantiw ishantiw self-assigned this Oct 23, 2022
@ishantiw ishantiw linked an issue Oct 23, 2022 that may be closed by this pull request
Update send function of Interoperability method #7562
Closed
sitetester
sitetester suggested changes Oct 24, 2022
View reviewed changes
framework/src/modules/interoperability/base_interoperability_method.ts Show resolved Hide resolved
framework/src/modules/interoperability/base_interoperability_method.ts Show resolved Hide resolved
framework/src/modules/interoperability/base_interoperability_method.ts Show resolved Hide resolved
framework/src/modules/interoperability/base_interoperability_method.ts Show resolved Hide resolved
framework/src/modules/interoperability/base_interoperability_method.ts Show resolved Hide resolved
framework/test/unit/modules/interoperability/method.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/interoperability/method.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/token/method.spec.ts Show resolved Hide resolved
framework/test/unit/modules/token/method.spec.ts Show resolved Hide resolved
framework/src/modules/interoperability/base_interoperability_method.ts Show resolved Hide resolved
@sitetester
Copy link
Contributor 

try:
        paramsSchema = JSON schema associated with (module, crossChainCommand)
        ccm.params = encode(paramsSchema, params)
    except Exception as e:
        emitPersistentEvent(
            module = MODULE_NAME_INTEROPERABILITY,
            name = EVENT_NAME_CCM_SENT_FAILED,
            data = {"ccm": ccm, "code": CCM_SENT_FAILED_CODE_INVALID_PARAMS},
            topics = []
        )
        raise e

Are we logging this event upon encode failure ?

This was referenced Oct 26, 2022
Closed
Closed
@ishantiw ishantiw merged commit d9e31db into feature/7211-interop-module-updates Oct 28, 2022
@ishantiw ishantiw deleted the 7562-update-send-func branch October 28, 2022 11:02
ishantiw added a commit that referenced this pull request Nov 14, 2022
@ishantiw
Update send method of Interoperability Store - Closes #7562 (#7682)
ef7c71e 
This PR resolves #7562

- Update send function based on updated LIP https://github.com/LiskHQ/lips/blob/main/proposals/lip-0045.md#sendinternal

`npm run test`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sitetester sitetester sitetester approved these changes

@Phanco Phanco Phanco approved these changes

Assignees

@ishantiw ishantiw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update send function of Interoperability method
3 participants
@ishantiw @sitetester @Phanco