This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update createTerminatedState in interoperability module - Closes #7559
#7675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuaki-u
force-pushed
the
7559-create-terminated-state-account
branch
from
8edc678
to
1d80d00
Compare
ishantiw
suggested changes
Oct 21, 2022
mitsuaki-u
force-pushed
the
7559-create-terminated-state-account
branch
from
1d80d00
to
81e2097
Compare
mitsuaki-u
force-pushed
the
7559-create-terminated-state-account
branch
from
81e2097
to
09f3340
Compare
ishantiw
reviewed
Oct 25, 2022
framework/src/modules/interoperability/base_interoperability_store.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/base_interoperability_store.ts
Outdated
Show resolved
Hide resolved
|
Looks good, Thank you @mitsuaki-u for the clarification |
Phanco
approved these changes
Oct 25, 2022
mitsuaki-u
force-pushed
the
7559-create-terminated-state-account
branch
from
09f3340
to
c13799f
Compare
ishantiw
approved these changes
Oct 25, 2022
…erminated-state-account
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7559
How was it solved?
createTerminatedStateHow was it tested?
Added unit tests