Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update token module interoperability methods - Closes #7577 #7613

Merged
merged 6 commits into from
Oct 11, 2022

Conversation

Incede
Copy link
Contributor

@Incede Incede commented Oct 5, 2022

What was the problem?

This PR resolves #7577

How was it solved?

Update as specified here and based on recent updates in previous PR's

How was it tested?

Added/updated unit tests

@Incede Incede requested a review from shuse2 October 5, 2022 23:43
@Incede Incede self-assigned this Oct 5, 2022
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
@Incede Incede requested a review from shuse2 October 6, 2022 17:01
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but overall looks good 🚀

framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
@Incede Incede requested a review from shuse2 October 6, 2022 23:56
@Incede Incede marked this pull request as ready for review October 6, 2022 23:56
@Incede Incede requested a review from has5aan October 6, 2022 23:59
framework/src/modules/token/cc_method.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/token/cc_method.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/token/cc_method.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/token/cc_method.spec.ts Outdated Show resolved Hide resolved
@Incede Incede requested a review from shuse2 October 11, 2022 07:59
@shuse2 shuse2 merged commit 965161c into feature/7211-update_token_module Oct 11, 2022
@shuse2 shuse2 deleted the 7577-update-interop branch October 11, 2022 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants