Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update transaction and command verify step to have partial header - Closes #7603 #7606

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Oct 3, 2022

What was the problem?

This PR resolves #7603

How was it solved?

  • Add header to VerifyTransactionRequest ABI call
  • Update ABI handler to use header from context if exist, otherwise use from request similar to execute transaction
  • Update caller of abiClient.verifyTransaction to have header. while calling with block, use the block otherwise last block header

How was it tested?

  • Check verifyTransaction and command.verify context has partial block header
  • Update unit tests

@shuse2 shuse2 self-assigned this Oct 3, 2022
@shuse2 shuse2 requested a review from ishantiw October 4, 2022 07:56
@shuse2 shuse2 force-pushed the 7603-update_verify_context branch 2 times, most recently from 8d9e51f to 0d626e7 Compare October 4, 2022 19:58
@shuse2 shuse2 merged commit 7a1c539 into development Oct 5, 2022
@shuse2 shuse2 deleted the 7603-update_verify_context branch October 5, 2022 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add header timestamp and height to CommandVerifyContext
3 participants