This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update mainchain registration command on sidechain module - Closes #7441 #7533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
changed the base branch from
development
to
7440_sidechain_reg_update
shuse2
suggested changes
Sep 19, 2022
framework/src/modules/interoperability/sidechain/commands/mainchain_registration.ts
Show resolved
Hide resolved
framework/src/modules/interoperability/sidechain/commands/mainchain_registration.ts
Show resolved
Hide resolved
framework/src/modules/interoperability/sidechain/commands/mainchain_registration.ts
Show resolved
Hide resolved
framework/src/modules/interoperability/sidechain/commands/mainchain_registration.ts
Show resolved
Hide resolved
framework/src/modules/interoperability/sidechain/commands/mainchain_registration.ts
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/sidechain/commands/mainchain_registration.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/sidechain/commands/mainchain_registration.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/sidechain/commands/mainchain_registration.spec.ts
Show resolved
Hide resolved
mitsuaki-u
force-pushed
the
7440_sidechain_reg_update
branch
from
6586fef
to
8494527
Compare
Incede
changed the base branch from
development
to
feature/7211-update-modules-events-err
Incede
changed the base branch from
feature/7211-update-modules-events-err
to
development
Incede
force-pushed
the
7441-mainchain-reg
branch
from
68c3b49
to
6934102
Compare
Incede
force-pushed
the
7441-mainchain-reg
branch
from
6934102
to
716bb25
Compare
shuse2
approved these changes
Sep 21, 2022
ishantiw
suggested changes
Sep 22, 2022
framework/src/modules/interoperability/sidechain/commands/mainchain_registration.ts
Show resolved
Hide resolved
ishantiw
approved these changes
Sep 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7441
How was it solved?
Update as specified
How was it tested?
Added and updated unit tests