-
Notifications
You must be signed in to change notification settings - Fork 454
Conversation
1dbd883
to
88dfc1d
Compare
88dfc1d
to
8f6e0d3
Compare
dedd854
to
08375f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall logic looks good to me, some general comments
framework-plugins/lisk-framework-chain-connector-plugin/package.json
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/test/unit/plugin.spec.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed only _calculateInboxUpdate
for the moment.
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall implementation looks good to me, there is a comment and also there is a recent change:
- CCU Params schema change => newCertificateThreshold->certificateThreshold
networkIdentifier
is removed andchainID
is used instead
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/test/unit/utils.spec.ts
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/test/unit/plugin.spec.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments but still reviewing the logic and will add more comments if needed
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/test/unit/plugin.spec.ts
Outdated
Show resolved
Hide resolved
7bb2a75
to
b675388
Compare
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts
Outdated
Show resolved
Hide resolved
62a974d
to
e2c72f7
Compare
What was the problem?
This PR resolves #7224
How was it solved?
Implementation of
_createCCUParams
,_calculateInboxUpdate
,_rawStateStoreKey
,_validateCertificate
and_verifyLiveness
functions.How was it tested?
Implemented unit tests.