This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Register multi signature update - Closes #7343 #7412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitetester
suggested changes
Aug 17, 2022
framework/test/unit/modules/auth/register_multisignature.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/auth/register_multisignature.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/auth/register_multisignature.spec.ts
Outdated
Show resolved
Hide resolved
ishantiw
force-pushed
the
7343-register-multi-signature-update
branch
2 times, most recently
from
ce57082
to
4d842f5
Compare
sitetester
approved these changes
Aug 22, 2022
- Update multisignature registration transaction creation based on the new schema defined in https://github.com/LiskHQ/lips/blob/main/proposals/lip-0041.md - Run generate script to update the fixtures
- Update protocol-specs according to new multisignature registration params schema
- Update lisk-transactions tests based on new ms registration tx schema
ishantiw
force-pushed
the
7343-register-multi-signature-update
branch
from
fa6bcf5
to
bc42d4c
Compare
sitetester
reviewed
Aug 24, 2022
Phanco
approved these changes
Aug 24, 2022
ishantiw
force-pushed
the
7343-register-multi-signature-update
branch
from
e1bd035
to
cb3daa9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7343
How was it solved?
♻️ Update multisignature protocol-specs
🌱 Add _isMultisignatureAccount
♻️ Add schema, constants and types for new MS registration transaction
♻️ Update MS registration verify/execute based on new params schema
✅ Update tests related to MS registration tx update
How was it tested?
npm run test:unit auth