This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Implement cross chain command for interoperability modules - Closes #7038 & #7039 #7165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
force-pushed
the
7038-7039-impl-ccu-mainchain
branch
from
5c1c633
to
7563ecb
Compare
This was
linked to
issues
May 13, 2022
ishantiw
requested review from
mitsuaki-u,
shuse2 and
Incede
and removed request for
mitsuaki-u
shuse2
suggested changes
May 13, 2022
framework/src/modules/interoperability/mainchain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/mainchain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/mainchain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/mainchain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/sidechain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/sidechain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/sidechain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
ishantiw
force-pushed
the
7038-7039-impl-ccu-mainchain
branch
from
588f89e
to
4f191c2
Compare
ishantiw
force-pushed
the
7038-7039-impl-ccu-mainchain
branch
from
4f191c2
to
12d04d6
Compare
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 17, 2022
framework/src/modules/interoperability/sidechain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
shuse2
reviewed
May 17, 2022
framework/src/modules/interoperability/sidechain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
shuse2
reviewed
May 17, 2022
framework/src/modules/interoperability/sidechain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
shuse2
reviewed
May 17, 2022
shuse2
reviewed
May 19, 2022
ishantiw
force-pushed
the
7038-7039-impl-ccu-mainchain
branch
from
209aaf8
to
11d57fe
Compare
shuse2
suggested changes
May 23, 2022
shuse2
suggested changes
May 24, 2022
Incede
suggested changes
May 25, 2022
framework/src/modules/interoperability/mainchain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/mainchain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/mainchain/commands/cc_update.ts
Outdated
Show resolved
Hide resolved
ishantiw
force-pushed
the
7038-7039-impl-ccu-mainchain
branch
from
d128dea
to
2cfb4b6
Compare
…gnature and checkCertificateTimestamp
Incede
approved these changes
May 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7038 & #7039
How was it solved?
♻️ Export calculateRootFromRightWitness from lisk-tree
🌱 Implement ccu on mainchain
🌱 Implement CCU command on sidechain
How was it tested?
npm run test:unit interoperability