Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add random module hooks with tests - Closes #6776, #6777, #6778 #6863

Merged

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Oct 24, 2021

What was the problem?

This PR resolves #6776 , resolves #6777 and #6778

How was it solved?

  • Add verifyBlock hook with test
  • Add afterGenesisBlockExecute hook with test
  • Add afterBlockExecute hook with test

How was it tested?

  • Add unit tests to cover all cases

@shuse2 shuse2 self-assigned this Oct 24, 2021
Base automatically changed from 6779-add-api-rand-module to feature/6554-improve-framework-architecture October 25, 2021 11:09
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

framework/src/modules/random/module.ts Outdated Show resolved Hide resolved
framework/src/testing/create_contexts.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@mehmetegemen mehmetegemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(♥_♥)

@shuse2 shuse2 merged commit 5d8199b into feature/6554-improve-framework-architecture Oct 28, 2021
@shuse2 shuse2 deleted the 6777-rand-module-hooks branch October 28, 2021 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants