Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Rename properties on lisk-transactions - Closes #6631 and #6632 #6831

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Oct 12, 2021

What was the problem?

This PR resolves #6631 and resolves #6632

How was it solved?

  • Update transaction library naming
  • Update naming on api-client for transactions and block
  • Remove account from api client
  • Update separator from : to _

How was it tested?

  • Check if all asset name is gone
  • Update unit tests

@shuse2 shuse2 self-assigned this Oct 12, 2021
@shuse2 shuse2 linked an issue Oct 12, 2021 that may be closed by this pull request
@shuse2 shuse2 marked this pull request as draft October 12, 2021 07:56
@shuse2 shuse2 force-pushed the 6631-update-lisk-transactions branch from dd08752 to fb5a2be Compare October 12, 2021 15:47
@shuse2 shuse2 marked this pull request as ready for review October 12, 2021 15:48
@shuse2 shuse2 changed the title Rename properties on lisk-transactions - Closes #6631 Rename properties on lisk-transactions - Closes #6631 and #6632 Oct 12, 2021
@shuse2 shuse2 linked an issue Oct 12, 2021 that may be closed by this pull request
elements/lisk-transactions/test/validate.spec.ts Outdated Show resolved Hide resolved
elements/lisk-transactions/test/validate.spec.ts Outdated Show resolved Hide resolved
elements/lisk-transactions/test/sign.spec.ts Outdated Show resolved Hide resolved
elements/lisk-api-client/src/codec.ts Outdated Show resolved Hide resolved
address: address.toString('hex'),
});
} catch (error) {
throw new Error(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error could also be auth module not found or some other error? so maybe more generic error, Unsupported application. Either module or action name does not exist

@shuse2 shuse2 requested a review from ishantiw October 15, 2021 13:15
elements/lisk-api-client/src/codec.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 merged commit 1e6a84b into feature/6554-improve-framework-architecture Oct 15, 2021
@shuse2 shuse2 deleted the 6631-update-lisk-transactions branch October 15, 2021 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update lisk-api-client to support format change Update lisk-transaction to support name change
3 participants