This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update endpoint to use _ separator - Closes #6622 and #6666
#6760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
force-pushed
the
6622-update_rpc_endpoint_naming
branch
from
b09f51b
to
4321a40
Compare
Base automatically changed from
6707-refactor_controller
to
feature/6554-improve-framework-architecture
September 10, 2021 09:27
shuse2
force-pushed
the
6622-update_rpc_endpoint_naming
branch
from
4321a40
to
06944b6
Compare
- Replace `:` with `_` - Remove plugin lifecycle hooks
shuse2
force-pushed
the
6622-update_rpc_endpoint_naming
branch
from
06944b6
to
af21e9a
Compare
ishantiw
reviewed
Sep 10, 2021
framework/test/functional/rpc-api/ipc/ipc_client_in_memory.spec.ts
Outdated
Show resolved
Hide resolved
shuse2
force-pushed
the
6622-update_rpc_endpoint_naming
branch
from
94c0cd8
to
f69cae6
Compare
ishantiw
approved these changes
Sep 10, 2021
mehmetegemen
approved these changes
Sep 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6622 and resolves #6666
How was it solved?
:with__plugin_:loadingFinishedwithloadedunloadedandunloadedWithError.How was it tested?