This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Create fee module class - Closes #6692 #6700
Merged
shuse2
merged 10 commits into
feature/6554-improve-framework-architecture
from
6692_fee_module
Aug 31, 2021
Merged
Create fee module class - Closes #6692 #6700
shuse2
merged 10 commits into
feature/6554-improve-framework-architecture
from
6692_fee_module
Aug 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
Aug 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment but LGTM
mitsuaki-u
requested review from
ManuGowda
and removed request for
mehmetegemen
August 31, 2021 07:47
shuse2
approved these changes
Aug 31, 2021
ManuGowda
reviewed
Aug 31, 2021
ManuGowda
approved these changes
Aug 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6692
How was it solved?
🌱 81db689
addDependencies
method to interact with token moduleverifyTransaction
andbeforeTransactionExecution
hooks🌱 16474ee
How was it tested?
To be added later.