Create fee module class - Closes #6692 #6700

mitsuaki-u · 2021-08-30T17:15:19Z

What was the problem?

This PR resolves #6692

How was it solved?

🌱 81db689

Create fee module class
Add addDependencies method to interact with token module
Add configuration options
Add verifyTransaction and beforeTransactionExecution hooks

🌱 16474ee

Add schemas for configuration inputs

How was it tested?

To be added later.

shuse2

one minor comment but LGTM

framework/src/modules/fee/module.ts

framework/src/modules/fee/types.ts

mitsuaki-u added 8 commits August 30, 2021 15:56

Create fee module index

2cd1657

Create api.ts

1ef9233

Create constants.ts

0e58c46

Create endpoint.ts

d4e11c3

Create schemas.ts

16474ee

Create types.ts

0efcf8f

Update types.ts

f98b7ed

Create fee module class

81db689

mitsuaki-u self-assigned this Aug 30, 2021

mitsuaki-u requested a review from shuse2 August 30, 2021 17:23

shuse2 requested a review from mehmetegemen August 30, 2021 17:36

shuse2 suggested changes Aug 30, 2021

View reviewed changes

framework/src/modules/fee/module.ts Outdated Show resolved Hide resolved

Update module.ts

088a7c3

mitsuaki-u requested review from ManuGowda and removed request for mehmetegemen August 31, 2021 07:47

mitsuaki-u added this to the Sprint 52 milestone Aug 31, 2021

shuse2 removed this from the Sprint 52 milestone Aug 31, 2021

shuse2 approved these changes Aug 31, 2021

View reviewed changes

ManuGowda reviewed Aug 31, 2021

View reviewed changes

framework/src/modules/fee/types.ts Outdated Show resolved Hide resolved

framework/src/modules/fee/types.ts Outdated Show resolved Hide resolved

framework/src/modules/fee/types.ts Outdated Show resolved Hide resolved

Update types.ts

b7007d7

shuse2 requested a review from ManuGowda August 31, 2021 11:57

ManuGowda approved these changes Aug 31, 2021

View reviewed changes

shuse2 merged commit ce1feac into feature/6554-improve-framework-architecture Aug 31, 2021

shuse2 deleted the 6692_fee_module branch August 31, 2021 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create fee module class - Closes #6692 #6700

Create fee module class - Closes #6692 #6700

mitsuaki-u commented Aug 30, 2021

shuse2 left a comment

Create fee module class - Closes #6692 #6700

Create fee module class - Closes #6692 #6700

Conversation

mitsuaki-u commented Aug 30, 2021

What was the problem?

How was it solved?

How was it tested?

shuse2 left a comment

Choose a reason for hiding this comment