-
Notifications
You must be signed in to change notification settings - Fork 454
Integrate state machine/consensus/generator components - Closes #6567 and #6568 #6624
Integrate state machine/consensus/generator components - Closes #6567 and #6568 #6624
Conversation
- Expose new state store - Expose new block and block header class - Remove handling of account and account related types - Remove state handling (consensus/chain state) - Remove state validation
- Update transaction property names to follow latest standards
- Update framework module and comman to be in new format - Update framework not to use BFT library - Update all tests - Temporally remove endpoint integration - Remove account related fixture creation - Add temporal system modules
a133dd6
to
a522917
Compare
5eda013
to
b3e1d03
Compare
b3e1d03
to
56172d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes:
- Concept of accounts is removed
- Logic movement from chain to framework for validator, consensus with domain separation
- Node registration simplification and exposing, endpoints, registry, etc..
Other comments:
- Not sure why we have files under state_store_v1 which was not meant to be at first place
elements/lisk-chain/src/state_store_v1/*
generatorPublicKey
reference still exists in lots of places- There are some changes which needs to be updated in other libraries, i guess they are covered in different issues?
@@ -0,0 +1,148 @@ | |||
/* | |||
* Copyright © 2019 Lisk Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Copyright © 2019 Lisk Foundation | |
* Copyright © 2021 Lisk Foundation |
const validators = await this.blockExecutor.getValidators(); | ||
const finalizedBlockSlot = this.blockExecutor.getSlotNumber(finalizedBlock.timestamp); | ||
const currentBlockSlot = this.blockExecutor.getSlotNumber(Math.floor(Date.now() / 1000)); | ||
const threeRounds = validators.length * 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of these values can be made constants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those values cannot be constant
- Move liskBFT and validator modules to modules folder
I think it is already deleted? it was just there to not make the breaking change in the previous PR
There are still lots of module referencing generatorPublicKey, which needs to be updated during the module implementation. Also, genesis block and integration fixtures has this.
I have created #6632 #6631 etc to address them, but most of the issues need to be handle after the module implementation |
3c375ab
to
77a3561
Compare
77a3561
to
9e119e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shuse2 there are format issues, rest looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that small comment, all looks good to me
What was the problem?
This PR resolves #6567 and resolves #6568
Goal of this PR is to setup the environment to start developing all the modules consistently.
Framework integration and functional tests will not work until all the modules are implemented again.
How was it solved?
lisk-chain
exposed functions and remove unused logic and functionalitiesHow was it tested?
lisk-chain
build and tests are updated