Integrate state machine/consensus/generator components - Closes #6567 and #6568 #6624

shuse2 · 2021-08-04T17:39:56Z

What was the problem?

This PR resolves #6567 and resolves #6568

Goal of this PR is to setup the environment to start developing all the modules consistently.
Framework integration and functional tests will not work until all the modules are implemented again.

How was it solved?

Update lisk-chain exposed functions and remove unused logic and functionalities
Remove all duplicated logics from lisk-framework/node
Connect the state machine / consensus / generator components in the node

How was it tested?

lisk-chain build and tests are updated

- Expose new state store - Expose new block and block header class - Remove handling of account and account related types - Remove state handling (consensus/chain state) - Remove state validation

- Update transaction property names to follow latest standards

- Update framework module and comman to be in new format - Update framework not to use BFT library - Update all tests - Temporally remove endpoint integration - Remove account related fixture creation - Add temporal system modules

ManuGowda

Overall changes:

Concept of accounts is removed
Logic movement from chain to framework for validator, consensus with domain separation
Node registration simplification and exposing, endpoints, registry, etc..

Other comments:

Not sure why we have files under state_store_v1 which was not meant to be at first place elements/lisk-chain/src/state_store_v1/*
generatorPublicKey reference still exists in lots of places
There are some changes which needs to be updated in other libraries, i guess they are covered in different issues?

elements/lisk-chain/src/block_header.ts

elements/lisk-chain/src/chain.ts

elements/lisk-chain/src/schema.ts

framework/src/node/consensus/consensus.ts

ManuGowda · 2021-08-10T09:18:46Z

framework/src/node/consensus/fork_choice/fork_choice_rule.ts

@@ -0,0 +1,148 @@
+/*
+ * Copyright © 2019 Lisk Foundation


Suggested change

* Copyright © 2019 Lisk Foundation

* Copyright © 2021 Lisk Foundation

ManuGowda · 2021-08-10T09:21:43Z

framework/src/node/consensus/synchronizer/block_synchronization_mechanism.ts

+		const validators = await this.blockExecutor.getValidators();
+		const finalizedBlockSlot = this.blockExecutor.getSlotNumber(finalizedBlock.timestamp);
+		const currentBlockSlot = this.blockExecutor.getSlotNumber(Math.floor(Date.now() / 1000));
+		const threeRounds = validators.length * 3;


some of these values can be made constants?

those values cannot be constant

framework/src/schema/application_config_schema.ts

- Move liskBFT and validator modules to modules folder

shuse2 · 2021-08-10T16:36:26Z

Not sure why we have files under state_store_v1 which was not meant to be at first place elements/lisk-chain/src/state_store_v1/*

I think it is already deleted? it was just there to not make the breaking change in the previous PR

generatorPublicKey reference still exists in lots of places

There are still lots of module referencing generatorPublicKey, which needs to be updated during the module implementation. Also, genesis block and integration fixtures has this.

There are some changes which needs to be updated in other libraries, i guess they are covered in different issues?

I have created #6632 #6631 etc to address them, but most of the issues need to be handle after the module implementation

ManuGowda

@shuse2 there are format issues, rest looks good.

elements/lisk-chain/test/unit/transactions.spec.ts

framework/src/node/consensus/constants.ts

ishantiw

Apart from that small comment, all looks good to me

shuse2 self-assigned this Aug 4, 2021

shuse2 added 4 commits August 6, 2021 10:49

🌱 Update lisk-chain

9a56c68

- Expose new state store - Expose new block and block header class - Remove handling of account and account related types - Remove state handling (consensus/chain state) - Remove state validation

♻️ Update transaction property names

90d047e

- Update transaction property names to follow latest standards

🔥 Remove duplicated codes

12dcc25

🌱 Update framework to use new components

fb456d6

- Update framework module and comman to be in new format - Update framework not to use BFT library - Update all tests - Temporally remove endpoint integration - Remove account related fixture creation - Add temporal system modules

shuse2 force-pushed the 6567-integrate_components branch from a133dd6 to a522917 Compare August 6, 2021 08:59

shuse2 requested review from ManuGowda, nazarhussain and ishantiw August 6, 2021 09:01

shuse2 marked this pull request as ready for review August 6, 2021 09:01

shuse2 removed the request for review from nazarhussain August 6, 2021 09:04

shuse2 force-pushed the 6567-integrate_components branch 7 times, most recently from 5eda013 to b3e1d03 Compare August 6, 2021 11:45

💅 Temporally disable buil/tests

56172d0

shuse2 force-pushed the 6567-integrate_components branch from b3e1d03 to 56172d0 Compare August 6, 2021 12:25

shuse2 mentioned this pull request Aug 6, 2021

Update lisk-transaction to support name change #6631

Closed

ManuGowda reviewed Aug 10, 2021

View reviewed changes

This was referenced Aug 10, 2021

Update eslint to include all projects #6639

Closed

Enable framework integration tests #6640

Closed

♻️ Move system modules to modules folder

1fa80e3

- Move liskBFT and validator modules to modules folder

shuse2 requested a review from ManuGowda August 10, 2021 16:27

shuse2 force-pushed the 6567-integrate_components branch from 3c375ab to 77a3561 Compare August 10, 2021 16:37

♻️ Fix typos and namings

9e119e0

shuse2 force-pushed the 6567-integrate_components branch from 77a3561 to 9e119e0 Compare August 10, 2021 16:57

♻️ Add finalized height logic back

312d6cd

ManuGowda approved these changes Aug 11, 2021

View reviewed changes

ishantiw reviewed Aug 11, 2021

View reviewed changes

elements/lisk-chain/test/unit/transactions.spec.ts Show resolved Hide resolved

framework/src/node/consensus/constants.ts Outdated Show resolved Hide resolved

♻️ Rename event contants and format

2b3a1f1

shuse2 requested a review from ishantiw August 11, 2021 12:48

ishantiw approved these changes Aug 11, 2021

View reviewed changes

shuse2 merged commit 82af382 into feature/6554-improve-framework-architecture Aug 11, 2021

shuse2 deleted the 6567-integrate_components branch August 11, 2021 13:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate state machine/consensus/generator components - Closes #6567 and #6568 #6624

Integrate state machine/consensus/generator components - Closes #6567 and #6568 #6624

shuse2 commented Aug 4, 2021

ManuGowda left a comment •

edited

Loading

ManuGowda Aug 10, 2021

ManuGowda Aug 10, 2021

shuse2 Aug 10, 2021

shuse2 commented Aug 10, 2021

ManuGowda left a comment

ishantiw left a comment

	* Copyright © 2019 Lisk Foundation
	* Copyright © 2021 Lisk Foundation

Integrate state machine/consensus/generator components - Closes #6567 and #6568 #6624

Integrate state machine/consensus/generator components - Closes #6567 and #6568 #6624

Conversation

shuse2 commented Aug 4, 2021

What was the problem?

How was it solved?

How was it tested?

ManuGowda left a comment • edited Loading

Choose a reason for hiding this comment

Overall changes:

Other comments:

ManuGowda Aug 10, 2021

Choose a reason for hiding this comment

ManuGowda Aug 10, 2021

Choose a reason for hiding this comment

shuse2 Aug 10, 2021

Choose a reason for hiding this comment

shuse2 commented Aug 10, 2021

ManuGowda left a comment

Choose a reason for hiding this comment

ishantiw left a comment

Choose a reason for hiding this comment

ManuGowda left a comment •

edited

Loading