This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix handling of genesis block - Closes #6573 #6576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6573
How was it solved?
Below code should be removed with next version.
https://github.com/LiskHQ/lisk-sdk/pull/6576/files#diff-49cf44fda1c05aeae79dd1cd2b4d4a9c886c801fa800e3a269c8ac7a7c3adb01R217
https://github.com/LiskHQ/lisk-sdk/pull/6576/files#diff-297a5ae4736c65ff2f6ec1123c0c5f5f46742686b058b4471684e45bcba79bf7R298
They are required because running testnet node will not call the
afterGenesisBlockApply
hook.The code will add the information from genesis block if it doesn't exist.
How was it tested?
Run 2 nodes with heavy genesis block (modified mainnet snapshot etc)