This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix handling of genesis block - Closes #6573 #6576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
force-pushed
the
6573-fix_common_block_resp
branch
5 times, most recently
from
5cc76bb
to
3cbb644
Compare
- Update not to hold genesis block in memory - Update getHighestCommonBlock to getHighestCommonBlockID
shuse2
force-pushed
the
6573-fix_common_block_resp
branch
from
3cbb644
to
e0070cb
Compare
ManuGowda
reviewed
Jul 13, 2021
shuse2
force-pushed
the
6573-fix_common_block_resp
branch
from
41b062d
to
f9e6332
Compare
ManuGowda
approved these changes
Jul 13, 2021
shuse2
force-pushed
the
6573-fix_common_block_resp
branch
from
f9e6332
to
5c52046
Compare
shuse2
force-pushed
the
6573-fix_common_block_resp
branch
from
246d28e
to
2a80293
Compare
ishantiw
approved these changes
Jul 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6573
How was it solved?
Below code should be removed with next version.
https://github.com/LiskHQ/lisk-sdk/pull/6576/files#diff-49cf44fda1c05aeae79dd1cd2b4d4a9c886c801fa800e3a269c8ac7a7c3adb01R217
https://github.com/LiskHQ/lisk-sdk/pull/6576/files#diff-297a5ae4736c65ff2f6ec1123c0c5f5f46742686b058b4471684e45bcba79bf7R298
They are required because running testnet node will not call the
afterGenesisBlockApplyhook.The code will add the information from genesis block if it doesn't exist.
How was it tested?
Run 2 nodes with heavy genesis block (modified mainnet snapshot etc)