Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Assign a new array to fields to new Account object - Closes #5134 #5135

Merged
merged 5 commits into from
Apr 9, 2020

Conversation

ishantiw
Copy link
Contributor

@ishantiw ishantiw commented Apr 8, 2020

What was the problem?

This PR resolves #5134

How was it solved?

Assign a new array to populate old values for a field in the constructor of Account class

How was it tested?

  1. Create a pom trx
  2. Broadcast the trx
  3. Check if the pomHeights value is updated for the reported delegate

@ishantiw ishantiw requested a review from shuse2 April 8, 2020 15:41
@ishantiw ishantiw self-assigned this Apr 8, 2020
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, can you add the test to check if the array instance is not the same?

@ishantiw ishantiw force-pushed the 5134_pomheights_not_updated branch from 0c4cbc1 to b699e63 Compare April 8, 2020 16:24
@ishantiw ishantiw requested a review from shuse2 April 8, 2020 16:25
@shuse2 shuse2 changed the base branch from development to release/4.0.0 April 9, 2020 07:12
@shuse2 shuse2 merged commit 2e6d38f into release/4.0.0 Apr 9, 2020
@shuse2 shuse2 deleted the 5134_pomheights_not_updated branch April 9, 2020 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PoM transaction is accepted but the pomHeights is not updated for an account in the DB
3 participants