This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Wrong selection for top 101 delegates as active delegates - Closes #5123 #5126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
Apr 7, 2020
…re more than what required to select
shuse2
approved these changes
Apr 7, 2020
shuse2
suggested changes
Apr 7, 2020
ManuGowda
approved these changes
Apr 7, 2020
shuse2
approved these changes
Apr 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
In one edge case, we were selecting 103 as active delegates.
This PR resolves #5123
How was it solved?
Fixed the max slots for active delegates to 101.
How was it tested?